Maks1mS/bubbles
1
0
Fork 0
mirror of https://github.com/Maks1mS/bubbles.git synced 2025-01-11 22:41:03 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix bug where scroll wheel could create duplicate lines on top and bottom

Browse Source
This commit is contained in:
Christian Rocha 2020-07-20 17:46:15 -04:00
parent 5a26cb0d8e
commit 5357dd61bd
No known key found for this signature in database
GPG Key ID: D6CC7A16E5878018
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
viewport/viewport.go
View File

@ -173,6 +173,12 @@ func (m *Model) LineDown(n int) (lines []string) {
return nil return nil
} }
// Make sure the number of lines by which we're going to scroll isn't
// greater than the number of lines we actually have left before we reach
// the bottom.
maxDelta := (len(m.lines) - 1) - (m.YOffset + m.Height) // number of lines - viewport bottom edge
n = min(n, maxDelta)
m.YOffset = min( m.YOffset = min(
m.YOffset+n, // target m.YOffset+n, // target
len(m.lines)-1-m.Height, // fallback len(m.lines)-1-m.Height, // fallback
@ -194,6 +200,10 @@ func (m *Model) LineUp(n int) (lines []string) {
return nil return nil
} }
// Make sure the number of lines by which we're going to scroll isn't
// greater than the number of lines we are from the top.
n = min(n, m.YOffset)
m.YOffset = max(m.YOffset-n, 0) m.YOffset = max(m.YOffset-n, 0)
if len(m.lines) > 0 { if len(m.lines) > 0 {