Maks1mS/bubbles
1
0
Fork 0
mirror of https://github.com/Maks1mS/bubbles.git synced 2025-03-20 07:33:44 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix(viewport): Guard against negative string repetitions (#196)

Browse Source
This commit is contained in:
Maas Lalani 2022-07-21 14:39:17 -04:00 committed by GitHub
parent e49b5573bc
commit e32dcde62a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
viewport/viewport.go
View File

@ -10,7 +10,7 @@ import (
) )
// New returns a new model with the given width and height as well as default // New returns a new model with the given width and height as well as default
// keymappings. // key mappings.
func New(width, height int) (m Model) { func New(width, height int) (m Model) {
m.Width = width m.Width = width
m.Height = height m.Height = height
@ -237,7 +237,7 @@ func Sync(m Model) tea.Cmd {
} }
// ViewDown is a high performance command that moves the viewport up by a given // ViewDown is a high performance command that moves the viewport up by a given
// numer of lines. Use Model.ViewDown to get the lines that should be rendered. // number of lines. Use Model.ViewDown to get the lines that should be rendered.
// For example: // For example:
// //
// lines := model.ViewDown(1) // lines := model.ViewDown(1)
@ -344,10 +344,10 @@ func (m Model) updateAsModel(msg tea.Msg) (Model, tea.Cmd) {
func (m Model) View() string { func (m Model) View() string {
if m.HighPerformanceRendering { if m.HighPerformanceRendering {
// Just send newlines since we're going to be rendering the actual // Just send newlines since we're going to be rendering the actual
// content seprately. We still need to send something that equals the // content separately. We still need to send something that equals the
// height of this view so that the Bubble Tea standard renderer can // height of this view so that the Bubble Tea standard renderer can
// position anything below this view properly. // position anything below this view properly.
return strings.Repeat("\n", m.Height-1) return strings.Repeat("\n", max(0, m.Height-1))
} }
lines := m.visibleLines() lines := m.visibleLines()