Update textinput for multi-char (IME) input in Bubble Tea master

go.mod

@@ -4,7 +4,7 @@ go 1.13
 
 require (
 	github.com/atotto/clipboard v0.1.2
-	github.com/charmbracelet/bubbletea v0.12.1
+	github.com/charmbracelet/bubbletea v0.12.2-0.20201101135743-116a0cfb8f37
 	github.com/mattn/go-runewidth v0.0.9
 	github.com/muesli/termenv v0.7.4
 	golang.org/x/crypto v0.0.0-20201016220609-9e8e0b390897 // indirect

go.sum

@@ -1,7 +1,7 @@
 github.com/atotto/clipboard v0.1.2 h1:YZCtFu5Ie8qX2VmVTBnrqLSiU9XOWwqNRmdT3gIQzbY=
 github.com/atotto/clipboard v0.1.2/go.mod h1:ZY9tmq7sm5xIbd9bOK4onWV4S6X0u6GY7Vn0Yu86PYI=
-github.com/charmbracelet/bubbletea v0.12.1 h1:t21pkG2IDBRduPbt2J64Dx5yt8yIidAkXwhhrc11SzY=
+github.com/charmbracelet/bubbletea v0.12.2-0.20201101135743-116a0cfb8f37 h1:BQLGyhKVE19a9XdNYcsnYlO9XHPlOVHIWM7+mmS014k=
-github.com/charmbracelet/bubbletea v0.12.1/go.mod h1:3gZkYELUOiEUOp0bTInkxguucy/xRbGSOcbMs1geLxg=
+github.com/charmbracelet/bubbletea v0.12.2-0.20201101135743-116a0cfb8f37/go.mod h1:3gZkYELUOiEUOp0bTInkxguucy/xRbGSOcbMs1geLxg=
 github.com/containerd/console v1.0.1 h1:u7SFAJyRqWcG6ogaMAx3KjSTy1e3hT9QxqX7Jco7dRc=
 github.com/containerd/console v1.0.1/go.mod h1:XUsP6YE/mKtz6bxc+I8UiKKTP04qjQL4qcS3XoQ5xkw=
 github.com/google/goterm v0.0.0-20190703233501-fc88cf888a3f h1:5CjVwnuUcp5adK4gmY6i72gpVFVnZDP2h5TmPScB6u4=

layouts/vertical.go

@@ -1,118 +0,0 @@
-package layouts
-
-import (
-	tea "github.com/charmbracelet/bubbletea"
-)
-
-// Model is the Bubble Tea model for a vertical layout element.
-type Model struct {
-	Index int
-	Items []tea.Model
-
-	// Focus indicates whether user focus should be on this component
-	focus bool
-}
-
-type FocusItem interface {
-	Focus() tea.Model
-	Blur() tea.Model
-}
-
-// NewModel creates a new model with default settings.
-func NewModel() Model {
-	return Model{}
-}
-
-// Update is the Tea update loop.
-func (m Model) Update(msg tea.Msg) (Model, tea.Cmd) {
-	if !m.focus {
-		return m, nil
-	}
-
-	switch msg := msg.(type) {
-	case tea.KeyMsg:
-		switch msg.String() {
-		case "shift+tab", "up":
-			m.Index--
-			if m.Index < 0 {
-				m.Index = len(m.Items) - 1
-			}
-			m.updateFocus()
-
-		case "tab", "down":
-			m.Index++
-			if m.Index >= len(m.Items) {
-				m.Index = 0
-			}
-			m.updateFocus()
-		}
-	}
-
-	cmd := m.updateItems(msg)
-	return m, cmd
-}
-
-// View renders the layout in its current state.
-func (m Model) View() string {
-	var view string
-
-	for _, v := range m.Items {
-		if mi, ok := v.(tea.Model); ok {
-			view += mi.View() + "\n"
-		}
-	}
-
-	return view
-}
-
-func (m *Model) updateFocus() {
-	for i, v := range m.Items {
-		if m.Index == i {
-			if fi, ok := v.(FocusItem); ok {
-				// new focused item
-				m.Items[i] = fi.Focus()
-			}
-		} else {
-			if fi, ok := v.(FocusItem); ok {
-				m.Items[i] = fi.Blur()
-			}
-		}
-	}
-}
-
-// Pass messages and models through to text input components. Only text inputs
-// with Focus() set will respond, so it's safe to simply update all of them
-// here without any further logic.
-func (m *Model) updateItems(msg tea.Msg) tea.Cmd {
-	var (
-		cmd  tea.Cmd
-		cmds []tea.Cmd
-	)
-
-	for i, v := range m.Items {
-		if mi, ok := v.(tea.Model); ok {
-			m.Items[i], cmd = mi.Update(msg)
-			if cmd != nil {
-				cmds = append(cmds, cmd)
-			}
-		}
-	}
-
-	return tea.Batch(cmds...)
-}
-
-// Focused returns the focus state on the model.
-func (m Model) Focused() bool {
-	return m.focus
-}
-
-// Focus sets the focus state on the model.
-func (m *Model) Focus() {
-	m.focus = true
-	m.updateFocus()
-}
-
-// Blur removes the focus state on the model.
-func (m *Model) Blur() {
-	m.focus = false
-}

textinput/textinput.go

@@ -67,7 +67,6 @@ type Model struct {
 	Cursor           string
 	BlinkSpeed       time.Duration
 	TextColor        string
-	FocusedTextColor string
 	BackgroundColor  string
 	PlaceholderColor string
 	CursorColor      string
@@ -115,7 +114,6 @@ func NewModel() Model {
 		Placeholder:      "",
 		BlinkSpeed:       defaultBlinkSpeed,
 		TextColor:        "",
-		FocusedTextColor: "205",
 		PlaceholderColor: "240",
 		CursorColor:      "",
 		EchoCharacter:    '*',
@@ -184,19 +182,15 @@ func (m Model) Focused() bool {
 }
 
 // Focus sets the focus state on the model.
-func (m Model) Focus() tea.Model {
+func (m *Model) Focus() {
 	m.focus = true
 	m.blink = m.cursorMode == cursorHide // show the cursor unless we've explicitly hidden it
-
-	return m
 }
 
 // Blur removes the focus state on the model.
-func (m Model) Blur() tea.Model {
+func (m *Model) Blur() {
 	m.focus = false
 	m.blink = true
-
-	return m
 }
 
 // Reset sets the input to its default state with no input. Returns whether
@@ -456,12 +450,8 @@ func (m Model) echoTransform(v string) string {
 	}
 }
 
-func (m Model) Init() tea.Cmd {
-	return Blink
-}
-
 // Update is the Bubble Tea update loop.
-func (m Model) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
+func (m Model) Update(msg tea.Msg) (Model, tea.Cmd) {
 	if !m.focus {
 		m.blink = true
 		return m, nil
@@ -518,17 +508,17 @@ func (m Model) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
 			m.offset = 0
 		case tea.KeyCtrlV: // ^V paste
 			return m, Paste
-		case tea.KeyRune: // input a regular character
+		case tea.KeyRunes: // input regular characters
-			if msg.Alt {
+			if msg.Alt && len(msg.Runes) == 1 {
-				if msg.Rune == 'd' { // alt+d, delete word right of cursor
+				if msg.Runes[0] == 'd' { // alt+d, delete word right of cursor
 					resetBlink = m.deleteWordRight()
 					break
 				}
-				if msg.Rune == 'b' { // alt+b, back one word
+				if msg.Runes[0] == 'b' { // alt+b, back one word
 					resetBlink = m.wordLeft()
 					break
 				}
-				if msg.Rune == 'f' { // alt+f, forward one word
+				if msg.Runes[0] == 'f' { // alt+f, forward one word
 					resetBlink = m.wordRight()
 					break
 				}
@@ -536,8 +526,8 @@ func (m Model) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
 
 			// Input a regular character
 			if m.CharLimit <= 0 || len(m.value) < m.CharLimit {
-				m.value = append(m.value[:m.pos], append([]rune{msg.Rune}, m.value[m.pos:]...)...)
+				m.value = append(m.value[:m.pos], append(msg.Runes, m.value[m.pos:]...)...)
-				resetBlink = m.SetCursor(m.pos + 1)
+				resetBlink = m.SetCursor(m.pos + len(msg.Runes))
 			}
 		}
 
@@ -570,14 +560,9 @@ func (m Model) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
 
 // View renders the textinput in its current state.
 func (m Model) View() string {
-	prompt := termenv.String(m.Prompt)
-	if m.focus {
-		prompt = prompt.Foreground(color(m.FocusedTextColor))
-	}
-
 	// Placeholder text
 	if len(m.value) == 0 && m.Placeholder != "" {
-		return prompt.String() + m.placeholderView()
+		return m.placeholderView()
 	}
 
 	value := m.value[m.offset:m.offsetRight]
@@ -605,7 +590,7 @@ func (m Model) View() string {
 		)
 	}
 
-	return prompt.String() + v
+	return m.Prompt + v
 }
 
 // placeholderView returns the prompt and placeholder view, if any.
@@ -625,7 +610,7 @@ func (m Model) placeholderView() string {
 	// The rest of the placeholder text
 	v += m.colorPlaceholder(p[1:])
 
-	return v
+	return m.Prompt + v
 }
 
 // cursorView styles the cursor.