From 8b09176b592dc9a312f775f6da4a4385d1dbd38d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mateusz=20Skowro=C5=84ski?= <skowri@gmail.com>
Date: Sun, 23 Dec 2018 18:06:57 +0100
Subject: [PATCH] Fix GCC 8 warning: catching polymorphic type by value
 [-Wcatch-value=]

---
 limereport/lrbasedesignintf.cpp      | 2 +-
 limereport/lrdatasourcemanager.cpp   | 6 +++---
 limereport/lrscriptenginemanager.cpp | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/limereport/lrbasedesignintf.cpp b/limereport/lrbasedesignintf.cpp
index ba3b71d..0427d2b 100644
--- a/limereport/lrbasedesignintf.cpp
+++ b/limereport/lrbasedesignintf.cpp
@@ -1372,7 +1372,7 @@ QObject *BaseDesignIntf::createElement(const QString& /*collectionName*/, const
             obj = LimeReport::DesignElementsFactory::instance().objectCreator(elementType)(this, this);
             connect(obj,SIGNAL(propertyChanged(QString,QVariant,QVariant)),page(),SLOT(slotItemPropertyChanged(QString,QVariant,QVariant)));
         }
-    } catch (ReportError error){
+    } catch (ReportError &error){
         qDebug()<<error.what();
     }
     return obj;
diff --git a/limereport/lrdatasourcemanager.cpp b/limereport/lrdatasourcemanager.cpp
index ad1cd58..a97220b 100644
--- a/limereport/lrdatasourcemanager.cpp
+++ b/limereport/lrdatasourcemanager.cpp
@@ -307,7 +307,7 @@ void DataSourceManager::connectAllDatabases()
     foreach(ConnectionDesc* conn,m_connections){
         try{
             connectConnection(conn);
-        } catch (ReportError e){
+        } catch (ReportError &e){
             putError(e.what());
             setLastError(e.what());
             qDebug()<<e.what();
@@ -323,7 +323,7 @@ bool DataSourceManager::addModel(const QString &name, QAbstractItemModel *model,
     try{
         putHolder(name, mh);
         connect(mh, SIGNAL(modelStateChanged()), this, SIGNAL(datasourcesChanged()));
-    } catch (ReportError e){
+    } catch (ReportError &e){
         putError(e.what());
         setLastError(e.what());
         return false;
@@ -871,7 +871,7 @@ void DataSourceManager::connectAutoConnections()
         if (conn->autoconnect()) {
             try {
                 connectConnection(conn);
-            } catch(ReportError e){
+            } catch(ReportError &e){
                 setLastError(e.what());
                 putError(e.what());
                 qDebug()<<e.what();
diff --git a/limereport/lrscriptenginemanager.cpp b/limereport/lrscriptenginemanager.cpp
index ae3abad..b00bc42 100644
--- a/limereport/lrscriptenginemanager.cpp
+++ b/limereport/lrscriptenginemanager.cpp
@@ -383,7 +383,7 @@ QString ScriptEngineManager::expandUserVariables(QString context, RenderPass /*
                     }
                     pos=0;
 
-                } catch (ReportError e){
+                } catch (ReportError &e){
                     dataManager()->putError(e.what());
                     if (!dataManager()->reportSettings() || dataManager()->reportSettings()->suppressAbsentFieldsAndVarsWarnings())
                         context.replace(rx.cap(0),e.what());